From 727081f99a5065787dd3d035f92ef9f502f3622c Mon Sep 17 00:00:00 2001
From: Aryadev Chavali <aryadev@aryadevchavali.com>
Date: Wed, 1 Nov 2023 14:23:48 +0000
Subject: Removed OP_EQ signed versions as they're useless

A negative number under 2s complement can never be equal to its
positive as the top bit *must* be on.  If two numbers are equivalent
bit-by-bit then they are equal for both signed and unsigned numbers.
---
 lib/inst.c | 17 ++++-------------
 lib/inst.h |  9 +++++----
 2 files changed, 9 insertions(+), 17 deletions(-)

(limited to 'lib')

diff --git a/lib/inst.c b/lib/inst.c
index 5be2438..98bbc98 100644
--- a/lib/inst.c
+++ b/lib/inst.c
@@ -108,18 +108,9 @@ const char *opcode_as_cstr(opcode_t code)
   case OP_EQ_BYTE:
     return "EQ_BYTE";
     break;
-  case OP_EQ_CHAR:
-    return "EQ_CHAR";
-    break;
-  case OP_EQ_INT:
-    return "EQ_INT";
-    break;
   case OP_EQ_HWORD:
     return "EQ_HWORD";
     break;
-  case OP_EQ_LONG:
-    return "EQ_LONG";
-    break;
   case OP_EQ_WORD:
     return "EQ_WORD";
     break;
@@ -270,7 +261,7 @@ void data_print(data_t datum, data_type_t type, FILE *fp)
 
 void inst_print(inst_t instruction, FILE *fp)
 {
-  static_assert(NUMBER_OF_OPCODES == 73, "inst_bytecode_size: Out of date");
+  static_assert(NUMBER_OF_OPCODES == 70, "inst_bytecode_size: Out of date");
   fprintf(fp, "%s(", opcode_as_cstr(instruction.opcode));
   if (OPCODE_IS_TYPE(instruction.opcode, OP_PUSH))
   {
@@ -300,7 +291,7 @@ void inst_print(inst_t instruction, FILE *fp)
 
 size_t inst_bytecode_size(inst_t inst)
 {
-  static_assert(NUMBER_OF_OPCODES == 73, "inst_bytecode_size: Out of date");
+  static_assert(NUMBER_OF_OPCODES == 70, "inst_bytecode_size: Out of date");
   size_t size = 1; // for opcode
   if (OPCODE_IS_TYPE(inst.opcode, OP_PUSH))
   {
@@ -324,7 +315,7 @@ size_t inst_bytecode_size(inst_t inst)
 
 void inst_write_bytecode(inst_t inst, darr_t *darr)
 {
-  static_assert(NUMBER_OF_OPCODES == 73, "inst_write_bytecode: Out of date");
+  static_assert(NUMBER_OF_OPCODES == 70, "inst_write_bytecode: Out of date");
   // Append opcode
   darr_append_byte(darr, inst.opcode);
   // Then append 0 or more operands
@@ -398,7 +389,7 @@ data_t read_type_from_darr(darr_t *darr, data_type_t type)
 
 inst_t inst_read_bytecode(darr_t *darr)
 {
-  static_assert(NUMBER_OF_OPCODES == 73, "inst_read_bytecode: Out of date");
+  static_assert(NUMBER_OF_OPCODES == 70, "inst_read_bytecode: Out of date");
   if (darr->used >= darr->available)
     return (inst_t){0};
   inst_t inst     = {0};
diff --git a/lib/inst.h b/lib/inst.h
index 929c068..ff1709e 100644
--- a/lib/inst.h
+++ b/lib/inst.h
@@ -62,10 +62,7 @@ typedef enum
   OP_XOR_WORD,
 
   OP_EQ_BYTE,
-  OP_EQ_CHAR,
   OP_EQ_HWORD,
-  OP_EQ_INT,
-  OP_EQ_LONG,
   OP_EQ_WORD,
 
   // Mathematical operations
@@ -75,24 +72,28 @@ typedef enum
   OP_LT_INT,
   OP_LT_LONG,
   OP_LT_WORD,
+
   OP_LTE_BYTE,
   OP_LTE_CHAR,
   OP_LTE_HWORD,
   OP_LTE_INT,
   OP_LTE_LONG,
   OP_LTE_WORD,
+
   OP_GT_BYTE,
   OP_GT_CHAR,
   OP_GT_HWORD,
   OP_GT_INT,
   OP_GT_LONG,
   OP_GT_WORD,
+
   OP_GTE_BYTE,
   OP_GTE_CHAR,
   OP_GTE_HWORD,
   OP_GTE_INT,
   OP_GTE_LONG,
   OP_GTE_WORD,
+
   OP_PLUS_BYTE,
   OP_PLUS_HWORD,
   OP_PLUS_WORD,
@@ -100,8 +101,8 @@ typedef enum
   // Simple I/O
   OP_PRINT_BYTE,
   OP_PRINT_CHAR,
-  OP_PRINT_INT,
   OP_PRINT_HWORD,
+  OP_PRINT_INT,
   OP_PRINT_LONG,
   OP_PRINT_WORD,
 
-- 
cgit v1.2.3-13-gbd6f