oreodave/ovm
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed bug where reading operand bytecode may stop prematurely

Browse Source 
This is due to checking for equality instead of just greater than in
darr->used against darr->available.
This commit is contained in:
Aryadev Chavali
2023-10-29 16:56:33 +00:00
parent 7c367f95c9
commit c4cb45f3ad
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
vm/inst.c
View File

@@ -287,13 +287,13 @@ data_t read_type_from_darr(darr_t *darr, data_type_t type)
case DATA_TYPE_NIL: case DATA_TYPE_NIL:
break; break;
case DATA_TYPE_BYTE: case DATA_TYPE_BYTE:
if (darr->used >= darr->available) if (darr->used > darr->available)
// TODO: Error (darr has no space left) // TODO: Error (darr has no space left)
return DBYTE(0); return DBYTE(0);
return DBYTE(darr->data[darr->used++]); return DBYTE(darr->data[darr->used++]);
break; break;
case DATA_TYPE_HWORD: case DATA_TYPE_HWORD:
if (darr->used + HWORD_SIZE >= darr->available) if (darr->used + HWORD_SIZE > darr->available)
// TODO: Error (darr has no space left) // TODO: Error (darr has no space left)
return DWORD(0); return DWORD(0);
hword u = 0; hword u = 0;
@@ -302,7 +302,7 @@ data_t read_type_from_darr(darr_t *darr, data_type_t type)
return DHWORD(u); return DHWORD(u);
break; break;
case DATA_TYPE_WORD: case DATA_TYPE_WORD:
if (darr->used + WORD_SIZE >= darr->available) if (darr->used + WORD_SIZE > darr->available)
// TODO: Error (darr has no space left) // TODO: Error (darr has no space left)
return DWORD(0); return DWORD(0);
word w = 0; word w = 0;