oreodave/ovm
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed bug with get_opcode_data_type

Browse Source 
Pushed the bits one step too far.
This commit is contained in:
Aryadev Chavali
2023-10-16 11:25:52 +01:00
parent 845d864bc0
commit 7380dd375a
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/inst.c
View File

@@ -11,6 +11,7 @@
*/ */
#include <stdbool.h> #include <stdbool.h>
#include <stdio.h>
#include <string.h> #include <string.h>
#include "./inst.h" #include "./inst.h"
@@ -19,13 +20,13 @@ data_type_t get_opcode_data_type(opcode_t opcode)
{ {
data_type_t type = DATA_TYPE_NIL; data_type_t type = DATA_TYPE_NIL;
if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH)) if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH))
type = opcode >> 1; type = (data_type_t)opcode;
else if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH_REGISTER)) else if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH_REGISTER))
type = opcode >> 2; type = opcode >> 1;
else if (OPCODE_IS_TYPE(opcode, OP_TYPE_POP)) else if (OPCODE_IS_TYPE(opcode, OP_TYPE_POP))
type = opcode >> 3; type = opcode >> 2;
else if (OPCODE_IS_TYPE(opcode, OP_TYPE_MOV)) else if (OPCODE_IS_TYPE(opcode, OP_TYPE_MOV))
type = opcode >> 4; type = opcode >> 3;
return type; return type;
} }
@@ -137,7 +138,7 @@ inst_t inst_read_bytecode(darr_t *darr)
if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH)) if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH))
inst.operand = read_type_from_darr(darr, get_opcode_data_type(opcode)); inst.operand = read_type_from_darr(darr, get_opcode_data_type(opcode));
// Read register (as a byte) // Read register (as a byte)
if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH_REGISTER) || else if (OPCODE_IS_TYPE(opcode, OP_TYPE_PUSH_REGISTER) ||
OPCODE_IS_TYPE(opcode, OP_TYPE_MOV)) OPCODE_IS_TYPE(opcode, OP_TYPE_MOV))
inst.operand = read_type_from_darr(darr, DATA_TYPE_BYTE); inst.operand = read_type_from_darr(darr, DATA_TYPE_BYTE);
// Otherwise opcode doesn't take operands // Otherwise opcode doesn't take operands