oreodave/ovm
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed OP_EQ signed versions as they're useless

Browse Source 
A negative number under 2s complement can never be equal to its
positive as the top bit *must* be on.  If two numbers are equivalent
bit-by-bit then they are equal for both signed and unsigned numbers.
This commit is contained in:
Aryadev Chavali
2023-11-01 14:23:48 +00:00
parent 90fb9816b4
commit 727081f99a
4 changed files with 12 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
vm/runtime.c
View File

@@ -55,7 +55,7 @@ const char *err_as_cstr(err_t err)
err_t vm_execute(vm_t *vm)
{
static_assert(NUMBER_OF_OPCODES == 73, "vm_execute: Out of date");
static_assert(NUMBER_OF_OPCODES == 70, "vm_execute: Out of date");
struct Program *prog = &vm->program;
if (prog->ptr >= prog->max)
return ERR_END_OF_PROGRAM;

5
vm/runtime.h
View File

@@ -181,9 +181,8 @@ static const stack_f STACK_ROUTINES[] = {
[OP_XOR_BYTE] = vm_xor_byte, [OP_XOR_HWORD] = vm_xor_hword,
[OP_XOR_WORD] = vm_xor_word,
[OP_EQ_BYTE] = vm_eq_byte, [OP_EQ_CHAR] = vm_eq_char,
[OP_EQ_INT] = vm_eq_int, [OP_EQ_HWORD] = vm_eq_hword,
[OP_EQ_LONG] = vm_eq_long, [OP_EQ_WORD] = vm_eq_word,
[OP_EQ_BYTE] = vm_eq_byte, [OP_EQ_HWORD] = vm_eq_hword,
[OP_EQ_WORD] = vm_eq_word,
[OP_LT_BYTE] = vm_lt_byte, [OP_LT_CHAR] = vm_lt_char,
[OP_LT_INT] = vm_lt_int, [OP_LT_HWORD] = vm_lt_hword,