From 71f644043aeaa2a4803987adf9f96a4500a7e2a2 Mon Sep 17 00:00:00 2001
From: Aryadev Chavali <aryadev@aryadevchavali.com>
Date: Thu, 2 Apr 2026 05:46:45 +0100
Subject: [PATCH] modes:mod|single: fix issue with footstool not taking other
 by reference

---
 src/modes/mod.rs    |  6 +++---
 src/modes/single.rs | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/modes/mod.rs b/src/modes/mod.rs
index f5c9074..8c439aa 100644
--- a/src/modes/mod.rs
+++ b/src/modes/mod.rs
@@ -9,7 +9,7 @@ pub enum Footstool {
 }
 
 pub trait Hand {
-    fn footstool(&self, other: Self) -> Footstool;
+    fn footstool(&self, other: &Self) -> Footstool;
 }
 
 mod tests {
@@ -22,8 +22,8 @@ mod tests {
         x: &T,
         y: &T,
     ) -> (Footstool, Footstool) {
-        let res1 = x.footstool(*y);
-        let res2 = y.footstool(*x);
+        let res1 = x.footstool(y);
+        let res2 = y.footstool(x);
         assert!(match (res1, res2) {
             (Footstool::None, Footstool::None)
             | (Footstool::None, Footstool::Half)
diff --git a/src/modes/single.rs b/src/modes/single.rs
index 9fa16a0..5c6ae8d 100644
--- a/src/modes/single.rs
+++ b/src/modes/single.rs
@@ -12,7 +12,7 @@ impl Single {
 use crate::modes::{Footstool, Hand};
 
 impl Hand for Single {
-    fn footstool(&self, other: Self) -> Footstool {
+    fn footstool(&self, other: &Self) -> Footstool {
         let self_abs = self.0.deck_abs();
         let other_abs = other.0.deck_abs();
 
@@ -76,7 +76,7 @@ mod tests {
                 (single_slice[0], single_slice[1], single_slice[2]);
 
             // A single is always full footstooled by itself
-            assert!(s1.footstool(s1) == Footstool::Full);
+            assert!(s1.footstool(&s1) == Footstool::Full);
 
             // Test general non-reflexivity of the footstool relation and get
             // back some results we'd like to verify further.
@@ -152,10 +152,10 @@ mod tests {
             let piv_after = Single(Card::from(i64::from(piv_copy.0) + 1));
             let piv_way_after = Single(Card::from(i64::from(piv_copy.0) + 2));
 
-            assert!(pivot.footstool(piv_copy) == Footstool::Full);
-            assert!(pivot.footstool(piv_before) == Footstool::Half);
-            assert!(piv_after.footstool(pivot) == Footstool::Half);
-            assert!(pivot.footstool(piv_way_after) == Footstool::None);
+            assert!(pivot.footstool(&piv_copy) == Footstool::Full);
+            assert!(pivot.footstool(&piv_before) == Footstool::Half);
+            assert!(piv_after.footstool(&pivot) == Footstool::Half);
+            assert!(pivot.footstool(&piv_way_after) == Footstool::None);
         }
     }
 }