From 555c8e127bfef006fd96b4d7ab90b2d1ee2c62e7 Mon Sep 17 00:00:00 2001
From: Aryadev Chavali <aryadev@aryadevchavali.com>
Date: Fri, 3 Apr 2026 05:35:38 +0100
Subject: [PATCH] card: make Rank|Suit::cards yield an iterator instead of a
 vector

---
 src/card.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/card.rs b/src/card.rs
index ce34c4f..b29de69 100644
--- a/src/card.rs
+++ b/src/card.rs
@@ -47,8 +47,8 @@ impl Rank {
     }
 
     /** Generate an iterator over all cards within a rank, ordered by Suit. */
-    pub fn cards(&self) -> impl Iterator<Item = Card> {
-        let n = *self as i64;
+    pub fn cards(self) -> impl Iterator<Item = Card> {
+        let n = self as i64;
         ((n * 4)..((n + 1) * 4)).map(Card::from)
     }
 }
@@ -60,8 +60,8 @@ impl Suit {
     }
 
     /** Generate an iterator over all cards within a suit, ordered by Suit. */
-    pub fn cards(&self) -> impl Iterator<Item = Card> {
-        Rank::iter_all().map(|rank| Card::make_playing_card(rank, *self))
+    pub fn cards(self) -> impl Iterator<Item = Card> {
+        Rank::iter_all().map(move |rank| Card::make_playing_card(rank, self))
     }
 }