oreodave/avm
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Little endian check for convert_*_to_*

Browse Source 
We don't need to perform the for loop if not necessary
This commit is contained in:
Aryadev Chavali
2024-04-28 20:53:44 +05:30
parent df16aa9b19
commit 8461dcf423
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/base.c
View File

@@ -73,27 +73,39 @@ word_t word_bctoh(word_t w)
hword_t convert_bytes_to_hword(const byte_t *bytes) hword_t convert_bytes_to_hword(const byte_t *bytes)
{ {
hword_t h = 0; hword_t h = 0;
for (size_t i = 0; i < HWORD_SIZE; ++i) if (LITTLE_ENDIAN)
h |= ((hword_t)(bytes[i]) << (8 * i)); memcpy(&h, bytes, HWORD_SIZE);
else
for (size_t i = 0; i < HWORD_SIZE; ++i)
h |= ((hword_t)(bytes[i]) << (8 * i));
return h; return h;
} }
word_t convert_bytes_to_word(const byte_t *bytes) word_t convert_bytes_to_word(const byte_t *bytes)
{ {
word_t h = 0; word_t h = 0;
for (size_t i = 0; i < WORD_SIZE; ++i) if (LITTLE_ENDIAN)
h |= ((word_t)(bytes[i]) << (8 * i)); memcpy(&h, bytes, WORD_SIZE);
else
for (size_t i = 0; i < WORD_SIZE; ++i)
h |= ((word_t)(bytes[i]) << (8 * i));
return h; return h;
} }
void convert_hword_to_bytes(hword_t w, byte_t *bytes) void convert_hword_to_bytes(hword_t w, byte_t *bytes)
{ {
hword_t be_h = hword_htobc(w); if (LITTLE_ENDIAN)
memcpy(bytes, &be_h, HWORD_SIZE); memcpy(bytes, &w, HWORD_SIZE);
else
for (size_t i = 0; i < HWORD_SIZE; ++i)
bytes[i] = WORD_NTH_BYTE(w, i);
} }
void convert_word_to_bytes(word_t w, byte_t *bytes) void convert_word_to_bytes(word_t w, byte_t *bytes)
{ {
word_t be_w = word_htobc(w); if (LITTLE_ENDIAN)
memcpy(bytes, &be_w, WORD_SIZE); memcpy(bytes, &w, WORD_SIZE);
else
for (size_t i = 0; i < WORD_SIZE; ++i)
bytes[i] = WORD_NTH_BYTE(w, i);
} }