oreodave/avm
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix stupid issues in prog_write_bytecode

Browse Source 
In particular, not writing the full words for the program header and
incrementing bytes prematurely.
This commit is contained in:
Aryadev Chavali
2024-06-18 23:48:54 +01:00
parent 99fb0a0e2e
commit 4e513dbf01
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/inst.c
View File

@@ -434,14 +434,15 @@ size_t prog_write_bytecode(prog_t program, byte_t *bytes, size_t size_bytes)
{ {
if (size_bytes < PROG_HEADER_SIZE || prog_bytecode_size(program) < size_bytes) if (size_bytes < PROG_HEADER_SIZE || prog_bytecode_size(program) < size_bytes)
return 0; return 0;
size_t b_iter = 0;
// Write program header i.e. the start and count // Write program header i.e. the start and count
word_t start = word_byteswap(program.start_address); convert_word_to_bytes(program.start_address, bytes);
*(bytes++) = start; b_iter += WORD_SIZE;
word_t count = word_byteswap(program.count); convert_word_to_bytes(program.count, bytes + b_iter);
*(bytes++) = count; b_iter += WORD_SIZE;
// Write instructions // Write instructions
size_t p_iter = 0, b_iter = PROG_HEADER_SIZE; size_t p_iter = 0;
for (; p_iter < program.count && b_iter < size_bytes; ++p_iter) for (; p_iter < program.count && b_iter < size_bytes; ++p_iter)
{ {
size_t written = size_t written =