oreodave/algorithms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qsort: clean up the implementation (forward walk rather than backward)

Browse Source
This commit is contained in:
Aryadev Chavali
2025-10-27 23:09:16 +00:00
parent 964e001dd5
commit 946006096b
1 changed files with 20 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
impls/qsort.cpp
View File

@@ -16,8 +16,6 @@
(A) ^= (B); \ (A) ^= (B); \
} while (0) } while (0)
#define TEST_SIZE 10
void print_arr(int *arr, int size) void print_arr(int *arr, int size)
{ {
printf("{\n"); printf("{\n");
@@ -28,44 +26,28 @@ void print_arr(int *arr, int size)
void quicksort(int *arr, int arr_size) void quicksort(int *arr, int arr_size)
{ {
#ifdef TRACE // TODO: Use a different sort for small enough sizes?
printf("before, arr="); if (arr_size > 1)
print_arr(arr, arr_size);
printf("\n");
#endif
// TODO Optimisation: for small arr_size, a different sort like the bubble
// sort may be better, instead of initialising new stack frames.
if (arr_size < 2)
return;
// TODO Optimisation: Use some heuristics to figure out a better pivot than
// some constant choice of element.
int pivot = 0;
int pivot_value = arr[0];
for (int i = 1; i < arr_size; ++i)
{ {
if (arr[i] <= pivot_value) // TODO: Choose a better pivot maybe?
{ int pivot = arr[arr_size - 1]; // Choose the last element as pivot
if (i != pivot) int pivot_index = -1;
SWAP(arr[i], arr[pivot]);
++pivot;
}
}
#ifdef TRACE for (int j = 0; j < arr_size; ++j)
printf("after, arr="); {
print_arr(arr, arr_size); if (arr[j] < pivot)
printf("\n"); {
#endif ++pivot_index;
// TODO Optimisation: Use a stack to do this instead of recursion. std::swap(arr[pivot_index], arr[j]);
// }
// This algorithm is similar to a pre order traversal/dfs, in this case on an }
// array where left and right partition are children nodes to the original
// array node. Also with recursion there's a real risk for very large std::swap(arr[pivot_index + 1], arr[arr_size - 1]);
// ARR_SIZE of running out of space in the call stack.
if (pivot != 0) // TODO: Use a stack here instead?
quicksort(arr, pivot); quicksort(arr, pivot_index + 1);
if (pivot < arr_size - 1) quicksort(arr + pivot_index + 1, arr_size - pivot_index - 1);
quicksort(arr + pivot + 1, arr_size - pivot - 1); }
} }
int main(void) int main(void)