oreodave/aal
Archived
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Preprocesser: Fix memory leak in including another file

Browse Source 
Fixed a memory leak when included files had an error in lexing due to
not adding them to the token bag before error handling.
This commit is contained in:
Aryadev Chavali
2024-07-10 01:35:42 +01:00
parent 6c3bd47c04
commit d54bea3276
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/preprocesser.cpp
View File

@@ -129,14 +129,14 @@ namespace Preprocesser
Lexer::Err lexer_err = Lexer::tokenise_buffer(tokens[i + 1]->content, Lexer::Err lexer_err = Lexer::tokenise_buffer(tokens[i + 1]->content,
content.value(), body); content.value(), body);
if (lexer_err.type != LET::OK) // Add tokens to the bag for deallocation later
return new Err{ET::IN_FILE_LEXING, token, nullptr, lexer_err}; // NOTE: We do this before errors so no memory leaks happen
// Here we add the tokens, freshly allocated, to the bag so we can
// free it later
new_token_bag.insert(std::end(new_token_bag), std::begin(body), new_token_bag.insert(std::end(new_token_bag), std::begin(body),
std::end(body)); std::end(body));
if (lexer_err.type != LET::OK)
return new Err{ET::IN_FILE_LEXING, token, nullptr, lexer_err};
file_map[name].body = body; file_map[name].body = body;
std::vector<Unit> body_units; std::vector<Unit> body_units;
Err *err = preprocess(body, body_units, new_token_bag, const_map, Err *err = preprocess(body, body_units, new_token_bag, const_map,