From e9eaba12d196e0b526fb24f549466ce76168634b Mon Sep 17 00:00:00 2001 From: Aryadev Chavali Date: Thu, 21 Aug 2025 08:34:37 +0100 Subject: Fix issues with buffer overflow when printing products of sv_copy Happens because we have no null terminator on the string - rookie mistake. --- main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main.c b/main.c index bbd10e5..8223ada 100644 --- a/main.c +++ b/main.c @@ -20,8 +20,9 @@ sv_t sv_copy(sv_t old) { - char *newstr = calloc(1, old.size * sizeof(*newstr)); + char *newstr = calloc(1, (old.size + 1) * sizeof(*newstr)); memcpy(newstr, old.data, old.size); + newstr[old.size] = '\0'; return SV(newstr, old.size); } -- cgit v1.2.3-13-gbd6f